<sys/syslimits.h> is not standardized, so portable programs should not need to rely on it. If there really is something that we need where <sys/syslimits.h> provided the limit but <limits.h> did not, then that would be a candidate for fixing in gnulib. But this patch did not turn up any compilation failures on Linux. * src/internal.h (includes): Drop unused header. * daemon/libvirtd.h (includes): Likewise. * configure.ac (AC_CHECK_HEADERS): Likewise. Based on a report by Matthias Bolte. --- configure.ac | 2 +- daemon/libvirtd.h | 4 ---- src/internal.h | 4 ---- 3 files changed, 1 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 4f5c2d7..233e4af 100644 --- a/configure.ac +++ b/configure.ac @@ -133,7 +133,7 @@ AC_CHECK_FUNCS([pthread_sigmask pthread_mutexattr_init]) LIBS=$old_libs dnl Availability of various common headers (non-fatal if missing). -AC_CHECK_HEADERS([pwd.h paths.h regex.h sys/syslimits.h sys/un.h \ +AC_CHECK_HEADERS([pwd.h paths.h regex.h sys/un.h \ sys/poll.h syslog.h mntent.h net/ethernet.h linux/magic.h \ sys/un.h sys/syscall.h]) diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h index d37c3fd..ea00d5c 100644 --- a/daemon/libvirtd.h +++ b/daemon/libvirtd.h @@ -38,10 +38,6 @@ # include <dbus/dbus.h> # endif -# ifdef HAVE_SYS_SYSLIMITS_H -# include <sys/syslimits.h> -# endif - # include <rpc/types.h> # include <rpc/xdr.h> # include "remote_protocol.h" diff --git a/src/internal.h b/src/internal.h index 0fa097c..5747a90 100644 --- a/src/internal.h +++ b/src/internal.h @@ -18,10 +18,6 @@ # define sa_assert(expr) /* empty */ # endif -# ifdef HAVE_SYS_SYSLIMITS_H -# include <sys/syslimits.h> -# endif - /* The library itself is allowed to use deprecated functions / * variables, so effectively undefine the deprecated attribute * which would otherwise be defined in libvirt.h. -- 1.7.4.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list