2011/5/14 Jason Helfman <jhelfman@xxxxxxx>: > On Sat, May 14, 2011 at 07:01:06AM +0200, Matthias Bolte thus spake: >> >> 2011/5/13 Eric Blake <eblake@xxxxxxxxxx>: >>> >>> On 05/12/2011 11:53 PM, Matthias Bolte wrote: >>>> >>>> kill, SIGTERM and SIGKILL require additional headers. >>>> --- >>>> Âsrc/util/command.c | Â Â2 ++ >>>> Â1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/src/util/command.c b/src/util/command.c >>>> index b488d55..b2a873b 100644 >>>> --- a/src/util/command.c >>>> +++ b/src/util/command.c >>>> @@ -22,9 +22,11 @@ >>>> Â#include <config.h> >>>> >>>> Â#include <poll.h> >>>> +#include <signal.h> >>> >>> Definitely. >>> >>>> Â#include <stdarg.h> >>>> Â#include <stdlib.h> >>>> Â#include <sys/stat.h> >>>> +#include <sys/types.h> >>> >>> Spurious. ÂGnulib already takes care of this (if it doesn't, and you get >>> a compile error due to not including <sys/types.h>, then please post >>> that to the gnulib list, and I'll fix it upstream). >> >> Actually I didn't test if sys/types.h is really necessary, I just >> included what the man page said and it worked then. But you're right, >> it only needs signal.h. >> >> I'm pushing this one with the signal.h addition only. >> >> Matthias >> > > I included this patch for FreeBSD, do I need to alter the patch to not > include types? You can find the patch I pushed here http://libvirt.org/git/?p=libvirt.git;a=commit;h=fe99c6b3c6911d3769f9faf2bcc9cba422e0c822 You can also use the original patch, including sys/types.h shouldn't hurt. > Please test the port, if you can. :) > Would love feedback! > > Thanks, > Jason > I did that, see the other mail. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list