Re: [PATCH 2/2] node_device: avoid null dereference on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/11/2011 10:26 AM, Laine Stump wrote:
> On 05/04/2011 07:37 PM, Eric Blake wrote:
>> If we plow on after udev_device_get_syspath fails, we will hit a NULL
>> dereference.  Clang found one due to strdup later in udevSetParent,
>> but in fact we hit a NULL dereference sooner because of the use of
>> STREQ within virNodeDeviceFindBySysfsPath.
>>
>> * src/conf/node_device_conf.h (virNodeDeviceFindBySysfsPath): Mark
>> path argument non-null.
>> * src/node_device/node_device_udev.c (udevSetParent): Avoid null
>> dereference.
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]