On Wed, May 11, 2011 at 16:15:42 +0300, Dan Kenigsberg wrote: > On Wed, May 11, 2011 at 12:59:07PM +0100, Daniel P. Berrange wrote: > > > > > > +/* > > + * This is invoked when there is some kind of error > > + * parsing data to/from the monitor. The VM can continue > > + * to run, but no further monitor commands will be > > + * allowed > > + */ > > +static void > > +qemuProcessHandleMonitorError(qemuMonitorPtr mon ATTRIBUTE_UNUSED, > > + virDomainObjPtr vm) > > I'm all for being graceful and polite, so this sounds good. > > However, events are bound to be lost. The solution would be more robust > if there was a way to query the state of the monitor (though I'm not > sure it is worth the hassle). I plan to add an API for querying monitor status so that an app can detect whether libvirt currently waits for a reply for qemu and how long and extending that to report that qemu monitor is broken will be quite straightforward. > PS, I wonder what VMM stands for in this context. Not virtual memory > manager, I suppose. VMM stands virtual machine manager, aka hypervisor. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list