2011/5/9 Eric Blake <eblake@xxxxxxxxxx>:
> On 05/07/2011 06:28 AM, Matthias Bolte wrote:
>> ---
>> Âdaemon/remote_generator.pl | Â Â4 ++--
>> Â1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
>> index b06e51a..8d62c37 100755
>> --- a/daemon/remote_generator.pl
>> +++ b/daemon/remote_generator.pl
>> @@ -380,7 +380,7 @@ elsif ($opt_b) {
>> Â Â Â Â Â Â Â Â Â Â Â} else {
>> Â Â Â Â Â Â Â Â Â Â Â Â Âpush(@args_list, "args->$2");
>> Â Â Â Â Â Â Â Â Â Â Â}
>> - Â Â Â Â Â Â Â Â} elsif ($args_member =~ m/^\/*/) {
>
> Ignore 0 or more / at the start of a line (which basically meant _every_
> single line that got to this =~ would match, regardless of whether it is
> a comment)...
>
>> + Â Â Â Â Â Â Â Â} elsif ($args_member =~ m/^(\/)?\*/) {
>
> vs. ignore literal '/*' or '*' at the start of a line (which catches
> both the start and a line continuation for /* */ comments, but misses //
> comments - then again, we don't use // comments). ÂLooks right to me, so:
>
> ACK.
>
We prefer /* */ comments, don't we? Therefore, the generator turns //
into an error intentionally.
Thanks, pushed.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list