Re: [PATCH v3 1/8] screenshot: Defining the public API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/10 Michal Privoznik <mprivozn@xxxxxxxxxx>:
> Add public API for taking screenshots of current domain console.
>
> * include/libvirt/libvirt.h.in: add virDomainScreenshot
> * src/libvirt_public.syms: Export new symbol
> ---
> Âinclude/libvirt/libvirt.h.in | Â Â7 +++++++
> Âsrc/libvirt_public.syms   Â|  Â5 +++++
> Â2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 5783303..0113629 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -670,6 +670,13 @@ int           virDomainCoreDump    (virDomainPtr domain,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âint flags);
>
> Â/*
> + * Screenshot of current domain console
> + */
> +char *         ÂvirDomainScreenshot   (virDomainPtr domain,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â virStreamPtr stream,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â unsigned int flags);
> +
> +/*

How do intent to handle multi-head domains here? The domain XML video
element has a heads argument and for example VirtualBox supports it.
Do we only support taking screenshots of the first monitor or do we
take an aggregated screenshot overall monitors?

> diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
> index b4aed41..5c9e6b4 100644
> --- a/src/libvirt_public.syms
> +++ b/src/libvirt_public.syms
> @@ -436,4 +436,9 @@ LIBVIRT_0.9.0 {
> Â Â Â Â virStorageVolUpload;
> Â} LIBVIRT_0.8.8;
>
> +LIBVIRT_0.9.1 {
> + Â Âglobal:
> + Â Â Â ÂvirDomainScreenshot;
> +} LIBVIRT_0.9.0;
> +

0.9.1 is already released so this should be 0.9.2 here.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]