On Fri, May 06, 2011 at 10:25:50AM -0600, Eric Blake wrote: > The rule of thumb is that any file generated by config.status > is a) reproducible by any user, b) dependent on configure options. > Therefore, it is inappropriate to include such generated files > in the tarball (for proof, Makefile is generated from Makefile.in; > the former is not in the tarball while the latter is). > [...] > diff --git a/Makefile.am b/Makefile.am > index 0b4ae9d..ecc7435 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -16,9 +16,9 @@ XML_EXAMPLES = \ > > EXTRA_DIST = \ > ChangeLog-old \ > - libvirt.spec libvirt.spec.in \ > + libvirt.spec.in \ Actually that part is wrong. The libvirt.spec need to be in the tarball to allow to build rpms from it. This breaks for example "make rpm". I reverted that part of the patch, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list