Re: [PATCH] maint: avoid comparisons to bool constants

Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> · Fri, 6 May 2011 08:42:36 +0200

2011/5/5 Eric Blake <eblake@xxxxxxxxxx>:
> HACKING already mentions that comparisons against literal 'true'
> are unsafe; for consistency, also shorten comparisons against 'false'.
>
> * src/conf/domain_conf.c (virDomainNetDefParseXML): Simplify.
> * src/nwfilter/nwfilter_gentech_driver.c
> (virNWFilterDomainFWUpdateCB): Likewise.
> * tools/virsh.c (cmdVolDownload, vshCommandRun, vshPrintExtra):
> Likewise.
> ---
> Âsrc/conf/domain_conf.c Â Â Â Â Â Â Â Â | Â Â2 +-
> Âsrc/nwfilter/nwfilter_gentech_driver.c | Â Â2 +-
> Âtools/virsh.c Â Â Â Â Â Â Â Â Â Â Â Â Â| Â Â8 ++++----
> Â3 files changed, 6 insertions(+), 6 deletions(-)
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list