Re: [PATCH 1/3] Add field to virDomainObjPtr to track "tainting"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/2011 05:28 AM, Daniel P. Berrange wrote:
> +bool virDomainObjTaint(virDomainObjPtr obj,
> +                       int taint)
> +{
> +    int flag = (1 << taint);

Undefined behavior if taint is out of bounds (>= 31).  Do we need a
sanity check, or to change the 'int taint' parameter to instead be 'enum
virDomainTaintFlags'?

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]