Re: [PATCH] remote: avoid null dereference on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/03/2011 11:28 AM, Eric Blake wrote:
> Clang found three instances of uninitialized use of nparams in
> the cleanup path.  Unfortunately, one is a false positive: clang
> couldn't see that ret->params.params_val is guaranteed to be
> NULL unless allocated within a function, and that nparams is
> guaranteed to be assigned prior to the allocation; hoisting the
> assignment to nparams to be earlier in the function shuts up
> that false positive.  But two of the reports also happened to
> highlight a real bug - the error path can dereference NULL.

I meant to add:

    Regression introduced in commit 158ba873.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]