On Tue, May 03, 2011 at 09:19:59AM -0600, Eric Blake wrote: > On 05/03/2011 07:09 AM, Daniel P. Berrange wrote: > > On Fri, Apr 29, 2011 at 03:21:03PM +0800, Osier Yang wrote: > >> Otherwise if there are inactive lxc domains, lxcStartup will > >> try to reconnect to sockets of these domains, which results in > >> errors in libvirtd log. > >> --- > >> src/lxc/lxc_driver.c | 3 +++ > >> 1 files changed, 3 insertions(+), 0 deletions(-) > >> > > I don't see how this can be correct. > > > > > So, AFAICT, this patch means we will never reconnect to any LXC > > VMs now. > > > > The correct solution, is to refactor LXC driver startup to work > > the same way as the QEMU driver startup. > > > > - Load all the live state XML files (to pick up running VMs) > > - Reconnect to all VMs > > - Load all the persistent config XML files (to pick up any additional > > inactive guets) > > Osier, can you get this done before 0.9.1, or are we better off > reverting commit 0e7f7f85 for the release and resolving this post-release? I vote for reverting it, since the original "problem" was merely a harmless message in the logs which isn't a release show stopper. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list