Re: [PATCH] nwfilter: Fix memory leak in the ebtables subdriver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/4/30 Eric Blake <eblake@xxxxxxxxxx>:
> On 04/30/2011 05:12 AM, Matthias Bolte wrote:
>> Call shutdown functions for all subcompontents in nwfilterDriverShutdown.
>
> s/subcompontents/subcomponents/ (twice)

Fixed.

>> +++ b/src/conf/nwfilter_conf.c
>> @@ -125,6 +125,7 @@ struct int_map {
>> Â * only one filter update allowed
>> Â */
>> Âstatic virMutex updateMutex;
>> +static bool initialized = false;
>
> You could omit '= false' and still get the same results, since static
> storage is guaranteed to be zero-initialized, but that's just style and
> does not have to be changed.
>
> ACK.
>

I pushed it unchanged, thanks.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]