On Fri, Apr 22, 2011 at 09:57:46 -0600, Eric Blake wrote:
> > @@ -2379,6 +2379,12 @@ virDomainCoreDump(virDomainPtr domain, const char *to, int flags)
> > goto error;
> > }
> >
> > + if ((flags & VIR_DUMP_CRASH) && (flags & VIR_DUMP_LIVE)) {
> > + virLibDomainError(VIR_ERR_INVALID_ARG,
> > + _("crash and live flags are mutually exclusive"));
>
>
> ACK, but incomplete. A few lines earlier, the documentation states:
>
> * @flags: extra flags, currently unused
> *
> * This method will dump the core of a domain on a given file for analysis.
>
> It would be a wise time to update the docs at the same time :)
Sure. I fixed that and pushed, thanks.
Jirka
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list