On Thu, 21 Apr 2011 13:19:29 -0600 Eric Blake <eblake@xxxxxxxxxx> wrote: > On 04/21/2011 01:22 AM, KAMEZAWA Hiroyuki wrote: > > > > Centralize device modification in the more flexible APIs, to allow future > > honoring of additional flags. Explicitly reject the > > VIR_DOMAIN_DEVICE_MODIFY_FORCE flag on attach/detach. > > > > Based on Eric Blake<eblake@xxxxxxxxxx>'s work. > > > > From: Eric Blake <eblake@xxxxxxxxxx> > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > > > * src/qemu/qemu_driver.c > > (qemudDomainAttachDevice)(qemudDomainAttachDeviceFlags): Swap bodies,rename... > > Where's the rename? > > > (qemudDomainDetachDevice, qemudDomainDetachDeviceFlags): Likewise. > > --- > > src/qemu/qemu_driver.c | 53 ++++++++++++++++++++++++++--------------------- > > 1 files changed, 29 insertions(+), 24 deletions(-) > > > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > index f6e503a..a8f3849 100644 > > --- a/src/qemu/qemu_driver.c > > +++ b/src/qemu/qemu_driver.c > > @@ -3786,8 +3786,8 @@ cleanup: > > } > > > > > > -static int qemudDomainAttachDevice(virDomainPtr dom, > > - const char *xml) > > +static int qemudDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, > > + unsigned int flags) > > I adjusted this to do s/qemud/qemu/ for the lines of code actually > touched in this patch, plus fallout. > > ACK and pushed with this squashed in. > Thank you. -Kame -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list