2011/4/18 Eric Blake <eblake@xxxxxxxxxx>:
> On 04/17/2011 12:30 AM, Matthias Bolte wrote:
>> Inspired by Eric Blake
>
> Good to know I'm setting expectations :)
>
>> ---
>> Âcfg.mk            |  45 ++++++++++++++++++++++++++++++++++-------
>> Âsrc/interface/netcf_driver.c | Â 43 ++++++++++++++++++---------------------
>> Âsrc/nodeinfo.c        |  Â2 +-
>> Âsrc/phyp/phyp_driver.c    |  18 ++++++++--------
>> Âsrc/util/stats_linux.c    |  Â2 +-
>> Â5 files changed, 68 insertions(+), 42 deletions(-)
>>
>> @@ -182,8 +183,7 @@ static int interfaceNumOfInterfaces(virConnectPtr conn)
>> Â Â Â Â Âconst char *errmsg, *details;
>> Â Â Â Â Âint errcode = ncf_error(driver->netcf, &errmsg, &details);
>> Â Â Â Â ÂinterfaceReportError(netcf_to_vir_err(errcode),
>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â "%s (netcf: %s - %s)",
>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â _("failed to get number of interfaces on host"),
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â _("failed to get number of interfaces on host (netcf: %s - %s)"),
>
> This rewrite looks sane. ÂI think that it would have also worked to use:
>
> _("%s (netcf: %s - %s"),
> _("failed to get number of interfaces on host"),
>
> but since I don't know whether translators would like that any better, I
> don't think you should bother changing it.
>
> ACK.
>
Thanks, pushed.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list