Re: [PATCH v2] Remove virConnectPtr from virRaiseErrorFull

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/4/16 Eric Blake <eblake@xxxxxxxxxx>:
> On 04/16/2011 02:32 AM, Matthias Bolte wrote:
>> And from all related macros and functions.
>> ---
>>
>> I posted v1 a year ago :)
>>
>> https://www.redhat.com/archives/libvir-list/2010-April/msg00164.html
>
> And I even ack'd it, but a lot has changed in the meantime.
>
>> +++ b/src/conf/cpu_conf.c
>> @@ -32,7 +32,7 @@
>> Â#define VIR_FROM_THIS VIR_FROM_CPU
>>
>> Â#define virCPUReportError(code, ...) Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> - Â ÂvirReportErrorHelper(NULL, VIR_FROM_CPU, code, __FILE__, Â Â Â\
>> + Â ÂvirReportErrorHelper(VIR_FROM_CPU, code, __FILE__, Â Â Â Â Â Â\
>> Â Â Â Â Â Â Â Â Â Â Â Â Â __FUNCTION__, __LINE__, __VA_ARGS__)
>
> The argument was truly unused, so this is a nice cleanup.
>
> ACK.
>

Thanks, pushed now. I can't remember why I didn't push v1 :)

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]