On 04/15/2011 02:26 PM, Jiri Denemark wrote: > On Tue, Apr 12, 2011 at 15:35:06 -0600, Eric Blake wrote: >> The current state of virsh parsing is that: >> >> all lookup the volume by path (technically, the last two also attempt >> a name lookup within a pool, whereas the first skips that step, but >> the end result is the same); meanwhile: > > Is example virsh command line missing here? Aargh. I wrote my commit message by using sample command prompts: # virsh ... But # is a comment character, and ate my message (and now I don't remember it off the top of my head). I'll have to figure that out again, and use $ prompts instead... >> * tools/virsh.c (opts_vol_create_from, opts_vol_clone) >> (opts_vol_upload, opts_vol_download, opts_vol_delete) >> (opts_vol_wipe, opts_vol_info, opts_vol_dumpxml, opts_vol_key) >> (opts_vol_path): List optional pool parameter after required >> arguments. >> --- >> tools/virsh.c | 20 ++++++++++---------- >> 1 files changed, 10 insertions(+), 10 deletions(-) > > Makes sense. I went through all virsh.c and didn't find more options that > would need fixing. The only options which don't follow this "optional after > required" rule are bool options which can safely stay where they are. > > ACK The review would have been much easier with a non-broken commit message, but you caught on to my drift. I'll post my revised commit message once I remember what it was... -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list