2011/4/14 Eric Blake <eblake@xxxxxxxxxx>:
> Ever since commit ebc46f, the destroy function built two command
> variants but only used one. ÂI went with the variant that matches
> the idiom used in the counterpart of phypBuildStoragePool.
>
> * src/phyp/phyp_driver.c (phypDestroyStoragePool): Avoid
> clobbering cmd. ÂFix error message typo.
> ---
> Âsrc/phyp/phyp_driver.c | Â 11 +----------
> Â1 files changed, 1 insertions(+), 10 deletions(-)
>
> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> index 5742d95..7aa494d 100644
> --- a/src/phyp/phyp_driver.c
> +++ b/src/phyp/phyp_driver.c
> @@ -2936,19 +2936,10 @@ phypDestroyStoragePool(virStoragePoolPtr pool)
> Â Â Â Â return -1;
> Â Â }
> Â Â cmd = virBufferContentAndReset(&buf);
> -
> - Â Âif (virAsprintf(&cmd,
> - Â Â Â Â Â Â Â Â Â Â"viosvrcmd -m %s --id %d -c "
> - Â Â Â Â Â Â Â Â Â Â"'rmsp %s'", managed_system, vios_id,
> - Â Â Â Â Â Â Â Â Â Âpool->name) < 0) {
> - Â Â Â ÂvirReportOOMError();
> - Â Â Â Âgoto cleanup;
> - Â Â}
> -
> Â Â ret = phypExec(session, cmd, &exit_status, conn);
>
> Â Â if (exit_status < 0) {
> - Â Â Â ÂVIR_ERROR(_("Unable to create Storage Pool: %s"), ret);
> + Â Â Â ÂVIR_ERROR(_("Unable to destroy Storage Pool: %s"), ret);
> Â Â Â Â goto cleanup;
> Â Â }
I just noticed that the driver uses VIR_ERROR in many places where
PHYP_ERROR should be used to report an actual libvirt API level error.
But that a problem for another patch.
ACK, to this one.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list