On 04/15/2011 03:25 AM, Christophe Fergeau wrote: > Hi Matthias, > > On Thu, Apr 14, 2011 at 07:18:27PM +0200, Matthias Bolte wrote: >> This is a speculative patch as I don't have gcc 4.6 at hand to test it. > > I no longer get the warning with this patch applied. At first I was worried > about the use of ATTRIBUTE_UNUSED (I assumed it meant "this var is unused, > feel free to optimize it away"), but gcc documentation indeed says: > "unused > This attribute, attached to a variable, means that the variable is > meant to be possibly unused. GCC will not produce a warning for this > variable." > > So this all looks good to me (aka ack from me) ACK from me as well; I went ahead and pushed it under the build-breaker rule. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list