[snip] I've fixed those OOMErrors and the whitespace already for v3 however I won't send the v3 of the patch until I get reply to this since some other approach may have to be chosen for the port = 0 things. comments inline ... > Hmm, why exactly are these port = 0 changes needed? Were they breaking > some tests? Exactly. It was breaking almost all of the xmconfigtests and sexpr2xmltests. The reason was that it was never set in the code to setup just one serial/parallel port and this is why it was breaking it. That's the reason for those changes to port = 0. [snip] > I think these test files would be better named serial-target-port-auto. Good, I'll do that name change for v3. Thanks, Michal -- Michal Novotny <minovotn@xxxxxxxxxx>, RHCE Virtualization Team (xen userspace), Red Hat -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list