2011/4/11 Eric Blake <eblake@xxxxxxxxxx>:
> On 04/10/2011 05:28 AM, Matthias Bolte wrote:
>> ---
>> Âsrc/esx/esx_vi_types.c | Â 20 ++++++++++----------
>> Â1 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c
>> index 9e23030..29a3c39 100644
>> --- a/src/esx/esx_vi_types.c
>> +++ b/src/esx/esx_vi_types.c
>> @@ -77,12 +77,12 @@
>>   Âint                                    \
>> Â Â ÂesxVI_##__type##_Validate(esxVI_##__type *item) Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> Â Â Â{ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
>> - Â Â Â Âconst char *type_name = esxVI_Type_ToString(esxVI_Type_##__type); Â Â \
>> + Â Â Â Âconst char *typeName = esxVI_Type_ToString(esxVI_Type_##__type); Â Â Â\
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> Â Â Â Â Âif (item->_type <= esxVI_Type_Undefined || Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> Â Â Â Â Â Â Âitem->_type >= esxVI_Type_Other) { Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> Â Â Â Â Â Â ÂESX_VI_ERROR(VIR_ERR_INTERNAL_ERROR, Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â\
>> - Â Â Â Â Â Â Â Â Â Â Â Â "%s object has invalid dynamic type", type_name); Â Â\
>> + Â Â Â Â Â Â Â Â Â Â Â Â _("%s object has invalid dynamic type"), typeName); Â\
>
> Hmm, cfg.mk already included ESX_VI_ERROR in the list of
> msg_gen_function that should have caught this at 'make syntax-check'
> time; I wonder why it was being overlooked. ÂOh, probably because
> sc_libvirt_unmarked_diagnostics states that it won't find lines where
> the format string is on a separate line. ÂSame goes for
> sc_unmarked_diagnostics from gnulib's maint.mk; wonder if there's a way
> to improve the syntax checker.
>
> At any rate, ACK.
>
Thanks, pushed.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list