2011/4/13 Daniel Veillard <veillard@xxxxxxxxxx>: > On Sun, Apr 10, 2011 at 01:27:56PM +0200, Matthias Bolte wrote: >> Generate lookup functions for managed object types. >> --- >> Âsrc/esx/esx_vi.c        | Â414 +++++++++++++++++++++++----------------- >> Âsrc/esx/esx_vi.h        |  Â2 + >> Âsrc/esx/esx_vi_generator.input |  28 +++- >> Âsrc/esx/esx_vi_generator.py  Â| Â411 ++++++++++++++++++++++++++++++++++++++-- >> Âsrc/esx/esx_vi_types.c     | Â349 ++++++---------------------------- >> Âsrc/esx/esx_vi_types.h     | Â102 ++--------- >> Â6 files changed, 728 insertions(+), 578 deletions(-) > > ÂHum, it's a fairly big patch, and I won't pretend to fully understand it. > A cursory look didn't raised any issue to me, and since you're the one > managing that code, the best is for you to push it and others to make > sure everything still works well, so the earlier the better :-) The actual resulting functional change in the driver is pretty small, but moving it to the generator was a bit more complex. It took me a moment to understand the details of my own code again to get the macros right. Overall I'm quite sure that I didn't break something in here, as its still working in my tests :) > > ÂACK, > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list