Re: [PATCH] esx: Cleanup VI generator code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/4/12 Daniel Veillard <veillard@xxxxxxxxxx>:
> On Sun, Apr 10, 2011 at 01:26:47PM +0200, Matthias Bolte wrote:
>> ---
>> Âsrc/esx/esx_vi_generator.py | Â177 +++++++++++++++++--------------------------
>> Â1 files changed, 71 insertions(+), 106 deletions(-)
>>
>> diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
>> index 3d068f3..622a34a 100755
>> --- a/src/esx/esx_vi_generator.py
>> +++ b/src/esx/esx_vi_generator.py
>> @@ -41,6 +41,11 @@ valid_occurrences = [OCCURRENCE__REQUIRED_ITEM,
>>
>>
>>
>> +def aligned(left, right):
>> + Â Âwhile len(left) < 59:
>> + Â Â Â Âleft += " "
>> +
>> + Â Âreturn left + right
>
> Âcrude but that works :-) for the generator it's fine,
>
> Â Âoverall I'm not sure many understand that code beside you,

Well, probably. Actually I thing the code of the generator isn't that
complex, but it missing documentation how it's working in general,
that's true.

It's somewhere on my todo list to improve the overall documentation of
the ESX driver codebase.

> Â Â ÂACK
>
> Daniel

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]