Re: [PATCH 1/5] phyp: Remove stack allocating a 4kb volume key and fix related memory leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/4/11 Daniel Veillard <veillard@xxxxxxxxxx>:
> On Sat, Apr 09, 2011 at 11:59:07AM +0200, Matthias Bolte wrote:
>> Don't pre-allocate 4kb per key, make phypVolumeGetKey allocate the memory.
>>
>> Make phypBuildVolume return the volume key instead of using pre-allocated
>> memory to store it.
>>
>> Also fix a memory leak in phypVolumeLookupByName when phypVolumeGetKey
>> fails. Fix another memory leak in phypVolumeLookupByPath in the success
>> path. Fix phypVolumeGetXMLDesc leaking voldef.key.
>> ---
>> Âsrc/phyp/phyp_driver.c | Â 98 ++++++++++++++++++++++++++---------------------
>> Âsrc/phyp/phyp_driver.h | Â Â1 -
>> Â2 files changed, 54 insertions(+), 45 deletions(-)
>>

> ÂACK, way nicer !
>
> Daniel

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]