On 04/13/2011 05:38 PM, Cole Robinson wrote: > On 04/13/2011 11:14 AM, Michal Novotny wrote: >> Hi, >> this is the commit to introduce the function to create new character >> device definition for the domain as advices by Cole Robinson >> <crobinso@xxxxxxxxxx>. >> >> The function is used on the relevant places and the make, make check >> and make syntax-check all passed. >> >> Michal >> >> Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx> >> Signed-off-by: Michal Novotny <mignov@xxxxxxxxx> >> --- >> src/conf/domain_conf.c | 20 +++++++++++++++++--- >> src/conf/domain_conf.h | 2 ++ >> src/libvirt_private.syms | 1 + >> src/qemu/qemu_command.c | 3 ++- >> src/xenxs/xen_xm.c | 3 ++- >> 5 files changed, 24 insertions(+), 5 deletions(-) >> > There's at least one other instance that needs changing in xenxs/xen_sxpr.c I tried to implement to xen_sxpr.c as well and it broke xen tests entirely (sexpr2xml and xmconfigtest) - almost all of the tests in those were failing so I dropped it. > And I really don't think we should commit this until there is a regression > test demonstrating the regression (and that this patch fixes it). I mentioned > this earlier: > > https://www.redhat.com/archives/libvir-list/2011-April/msg00287.html Not sure about implementing this is necessary since there are already some tests - and they were failing when xen_sexpr.c was patched. Michal -- Michal Novotny <minovotn@xxxxxxxxxx>, RHCE Virtualization Team (xen userspace), Red Hat -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list