On 03/04/2011 09:30 AM, Jiri Denemark wrote: > On Fri, Mar 04, 2011 at 10:20:33 +0000, Daniel P. Berrange wrote: >>> ACK if you squash this in (did you forget to run 'make check'?): >> >> Urgh yes. I find it really annoying that plain 'make' does not >> cause the test suite to be compiled anymore:-( It certainly used >> to, but we lost it at some point & I've not checked where yet. > > I remember there was an explicit patch to move test suite compilation to the > check phase since it's not normally needed... Yep - commit 2bd24003b99, in Aug 2010. Is it worth a patch that would add a configure variable, such as ./configure --enable-test-builds, which can be used to always compile the tests for development, but leave test compilation optional for others that only want it built if they plan on running 'make check'? It would be a matter of setting up an automake variable, something like: tests = virshtest conftest ... if ENABLE_TEST_BUILDS noinst_PROGRAMS = $tests else check_PROGRAMS = $tests endif Or is it not worth the bother, where I can just be lazy and leave things the way they are. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list