Any review on this? Just found there is no reply yet. Michal On 04/01/2011 12:45 PM, Michal Novotny wrote: > Hi, > this is the patch to introduce the TXT record and DNS hosts support > for the DNS service on the virtual network. This can be defined using > the txt-record subelement in the dns element of the network XML > description. The definition of TXT record names containing spaces > is rejected with the error message that TXT record names in DNS > doesn't support spaces. > > Also, regression testing for the dnsmasq command line has been > added to test whether the dnsmasq command-line is correct or not. > > The new XML definition syntax is: > > <dns> > <txt-record name="example" value="example value" /> > <host ip='192.168.122.1'> > <hostname>gateway</hostname> > <hostname>host</hostname> > </host> > </dns> > > Where multiple host elements can be defined to put the aliases > for specified IP addresses. > > The patch series has been tested for the configuration and it > was working fine and also RelaxNG schema with the tests have > been both altered to add test cases to test those patches. > > All of the patches passed the make, make check and make > syntax-check commands and it has been tested for the definition > described above and it was working fine (tested using dig for > DNS TXT record and nslookup in the guest for the DNS hosts). > > Michal > > Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx> > > Michal Novotny (5): > Network: Add TXT record support for virtual DNS service > Network: Add regression tests for the command line arguments > Network: Move dnsmasqContext creation to > networkSaveDnsmasqHostsfile() and pass to dnsmasq only if > applicable > Network: Add additional hosts internal infrastructure > Network: Add support for DNS hosts definition in the network XML > > docs/formatnetwork.html.in | 31 +++- > docs/schemas/network.rng | 20 ++ > src/conf/network_conf.c | 183 ++++++++++++++ > src/conf/network_conf.h | 25 ++ > src/libvirt_private.syms | 1 + > src/network/bridge_driver.c | 103 ++++++-- > src/network/bridge_driver.h | 3 + > src/util/dnsmasq.c | 266 +++++++++++++++++++- > src/util/dnsmasq.h | 22 ++- > tests/Makefile.am | 11 + > tests/networkxml2argvdata/isolated-network.argv | 1 + > tests/networkxml2argvdata/isolated-network.xml | 11 + > .../networkxml2argvdata/nat-network-dns-hosts.argv | 1 + > .../networkxml2argvdata/nat-network-dns-hosts.xml | 19 ++ > .../nat-network-dns-txt-record.argv | 1 + > .../nat-network-dns-txt-record.xml | 24 ++ > tests/networkxml2argvdata/nat-network.argv | 1 + > tests/networkxml2argvdata/nat-network.xml | 21 ++ > tests/networkxml2argvdata/netboot-network.argv | 1 + > tests/networkxml2argvdata/netboot-network.xml | 14 + > .../networkxml2argvdata/netboot-proxy-network.argv | 1 + > .../networkxml2argvdata/netboot-proxy-network.xml | 13 + > tests/networkxml2argvdata/routed-network.argv | 1 + > tests/networkxml2argvdata/routed-network.xml | 9 + > tests/networkxml2argvtest.c | 120 +++++++++ > tests/networkxml2xmlin/nat-network-dns-hosts.xml | 27 ++ > .../nat-network-dns-txt-record.xml | 24 ++ > tests/networkxml2xmlout/nat-network-dns-hosts.xml | 27 ++ > .../nat-network-dns-txt-record.xml | 24 ++ > tests/networkxml2xmltest.c | 2 + > 30 files changed, 974 insertions(+), 33 deletions(-) > create mode 100644 tests/networkxml2argvdata/isolated-network.argv > create mode 100644 tests/networkxml2argvdata/isolated-network.xml > create mode 100644 tests/networkxml2argvdata/nat-network-dns-hosts.argv > create mode 100644 tests/networkxml2argvdata/nat-network-dns-hosts.xml > create mode 100644 tests/networkxml2argvdata/nat-network-dns-txt-record.argv > create mode 100644 tests/networkxml2argvdata/nat-network-dns-txt-record.xml > create mode 100644 tests/networkxml2argvdata/nat-network.argv > create mode 100644 tests/networkxml2argvdata/nat-network.xml > create mode 100644 tests/networkxml2argvdata/netboot-network.argv > create mode 100644 tests/networkxml2argvdata/netboot-network.xml > create mode 100644 tests/networkxml2argvdata/netboot-proxy-network.argv > create mode 100644 tests/networkxml2argvdata/netboot-proxy-network.xml > create mode 100644 tests/networkxml2argvdata/routed-network.argv > create mode 100644 tests/networkxml2argvdata/routed-network.xml > create mode 100644 tests/networkxml2argvtest.c > create mode 100644 tests/networkxml2xmlin/nat-network-dns-hosts.xml > create mode 100644 tests/networkxml2xmlin/nat-network-dns-txt-record.xml > create mode 100644 tests/networkxml2xmlout/nat-network-dns-hosts.xml > create mode 100644 tests/networkxml2xmlout/nat-network-dns-txt-record.xml > -- Michal Novotny <minovotn@xxxxxxxxxx>, RHCE Virtualization Team (xen userspace), Red Hat -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list