I wish I could have come up with something with fewer lines of code changed; but I'm at least happy that the end result only touched vshCommandParse and its helper functions rather than having to touch lots of existing commands. This fixes multiple bugs: a regression in 'virsh freecell 0' parsing, as well as an infelicity in 'virsh vol-create --pool default vol.xml' handling. It also makes it so that 'virsh vol-info vol-name pool-name' works without having to specify an explicit --pool argument. Eric Blake (2): virsh: list required options first virsh: fix regression in parsing optional integer tools/virsh.c | 169 ++++++++++++++++++++++++++++++++++++++------------------- 1 files changed, 114 insertions(+), 55 deletions(-) -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list