On 04/10/2011 09:18 AM, Matthias Bolte wrote:
> This will be used to make esxVI_Context clonable.
>
> Also move cleanup code for esxPrivate to esxFreePrivate().
> ---
> src/esx/esx_driver.c | 103 ++++++++++++++++++++++++-------------------------
> src/esx/esx_private.h | 4 +-
> 2 files changed, 52 insertions(+), 55 deletions(-)
ACK; looks like a relatively straightforward refactor, followed by lots
of renaming fallout.
> @@ -1070,14 +1072,9 @@ esxClose(virConnectPtr conn)
> esxVI_Logout(priv->vCenter) < 0) {
> result = -1;
> }
> -
> - esxVI_Context_Free(&priv->vCenter);
> }
>
> - virCapabilitiesFree(priv->caps);
> -
> - VIR_FREE(priv->transport);
> - VIR_FREE(priv);
> + esxFreePrivate(&priv);
>
> conn->privateData = NULL;
Is this line now redundant, since priv was initialized as
conn->privateData, and esxFreePrivate(&priv) guarantees that priv will
be reassigned to NULL?
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list