> Two suggestions: > > - when vcpupin an inactive domain, it gives an error message like this: > > error: Requested operation is not valid: cannot pin vcpus on an inactive domain > > After applying this series, this is not true anymore. I think a > message like this is more helpful: > > Failed to pin vcpus on inactive domain, please check the --config option. I think your pointing out is reasonable, I'll change that message. > - While it can vcpupin an inactive domain, it seems reasonable to be > able to view vcpuinfo of inactive domain, so would a patch to > vcpuinfo command be included? > I shelve that work. Probably that patch should be separated. Best regards, Taku Izumi -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list