On 03/30/2011 11:30 PM, Taku Izumi wrote:
>
> This patch introduces VIR_DOMAIN_MEM_MAXIMUM flag.
>
> Signed-off-by: Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>
> ---
> include/libvirt/libvirt.h.in | 1 +
> src/libvirt.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> Index: libvirt/include/libvirt/libvirt.h.in
> ===================================================================
> --- libvirt.orig/include/libvirt/libvirt.h.in
> +++ libvirt/include/libvirt/libvirt.h.in
> @@ -857,6 +857,7 @@ typedef enum {
> VIR_DOMAIN_MEM_CURRENT= 0, /* affect current domain */
This part of the patch doesn't exist. Am I missing some other patch
series that should have been applied first?
[goes back and re-reads - yep, you said so in mail 0/4]. OK, I'll
review that first. But I've now applied 1/4 from this series from when
it was first acked.
> VIR_DOMAIN_MEM_LIVE = (1 << 0), /* affect active domain */
> VIR_DOMAIN_MEM_CONFIG = (1 << 1), /* affect next boot */
> + VIR_DOMAIN_MEM_MAXIMUM= (1 << 2), /* affect Max rather than current */
I'll probably reindent things to put a space before = and line up the
other lines, but that's trivial.
> Index: libvirt/src/libvirt.c
> ===================================================================
> --- libvirt.orig/src/libvirt.c
> +++ libvirt/src/libvirt.c
> @@ -2869,6 +2869,8 @@ error:
> * the XML description on the domain. If neither flag is specified
> * (=VIR_DOMAIN_MEM_CURRENT), behavior is different depending on hypervisor.
> *
> + * If @flags incluces VIR_DOMAIN_MEM_MAXIMUM,
> + *
Incomplete sentence.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list