Thank you for reviewing!
>> + if ((flags& (VIR_DOMAIN_VCPU_LIVE | VIR_DOMAIN_MEM_CONFIG)) == 0) {
>
> s/VIR_DOMAIN_MEM_CONFIG/VIR_DOMAIN_VCPU_CONFIG/
Oops!. orz
> This allows both "LIVE" and "CONFIG" are set, and you use two
> "if" clauses later for both of them, (
> if (flags& VIR_DOMAIN_VCPU_CONFIG), and
> if (flags& VIR_DOMAIN_VCPU_LIVE) ) so there should be problem.
>
> IMHO it should be: Exactly one of "LIVE" or "CONFIG" is set.
I think "LIVE" and "CONIFG" can coexist, so it is allowed to
set at the same time.
Best regards,
Taku Izumi
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list