Re: [PATCH] free tmp after unlinking it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At 03/31/2011 06:49 PM, Daniel P. Berrange Write:
> On Thu, Mar 31, 2011 at 04:23:33PM +0800, Wen Congyang wrote:
>> ---
>>  src/qemu/qemu_driver.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index dd12dc8..5aa715e 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
>> @@ -5065,9 +5065,9 @@ endjob:
>>          vm = NULL;
>>  
>>  cleanup:
>> -    VIR_FREE(tmp);
>>      VIR_FORCE_CLOSE(fd);
>>      unlink (tmp);
>> +    VIR_FREE(tmp);
>>      if (vm)
>>          virDomainObjUnlock(vm);
>>      return ret;
> 
> ACK, but can you write a bit of a longer commit message
> saying what area of code / method this is fixing, because
> the diff context is not showing the method name.

I added a commit message and pushed it.
Thanks.

> 
> Daniel

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]