On 03/28/2011 03:29 AM, Daniel P. Berrange wrote: >>> if WITH_LIBXL >>> libvirtd_LDADD += ../src/libvirt_driver_libxl.la >>> + libvirtd_LDADD += ../src/libvirt_xenxs.la >>> + libvirtd_LDADD += ../src/libvirt_util.la >>> + libvirtd_LDADD += ../src/libvirt_conf.la >>> endif >>> >> >> I'd like to get another opinion on this hunk. Although I cant find any >> issues with it, I'd just like to ensure there is not a more appropriate >> way to add these libs. > > libvirtd is linked against libvirt.so, so it is already able to > get access to any symbols in libvirt_util.la or libvirt_conf.la, > *provided* the symbols are listed in libvirt_private.syms. > > I'm guessing there were one or two not listed in the private > exports file, making it appear that these extra linker lines > were needed. Just add the extra symbols to that file and you > should be fine I already have a patch pending review that does just that: [shoot; my regular list archives are down right now, so I have to find an alternate one...] http://thread.gmane.org/gmane.comp.emulators.libvirt/35859/focus=35865 -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list