On Mon, Mar 28, 2011 at 10:32:47AM +0200, Markus Groß wrote:
> This series of patches adds new functionality to the libxl driver.
>
> V2:
> - Incorporated review from Jim Fehlig
> - Allow domainGetSchedulerType only on active domains
> - Fix warnings about virDomainObjUnref
>
> Markus Groß (8):
> Ignore return value of virDomainObjUnref
> Add event callbacks to libxl driver
> List authors in copyright headers
> Add vcpu functions to libxl driver
> Add domainXMLFromNative/domainXMLToNative to libxl driver
> Add domainGetSchedulerType to libxl driver
> Add domainGetOSType to libxl driver
> Add domainSuspend/Resume to libxl driver
>
> configure.ac | 2 +
> daemon/Makefile.am | 3 +
> src/Makefile.am | 8 +-
> src/libxl/libxl_conf.c | 3 +
> src/libxl/libxl_conf.h | 11 +-
> src/libxl/libxl_driver.c | 823 +++++++++++++++++++++++++++++++++++++++++++++-
> src/libxl/libxl_driver.h | 3 +
> 7 files changed, 832 insertions(+), 21 deletions(-)
Hum, we are supposed to be in freeze but it seems ti would be a shame
to not pick them for 0.9.0:
- this can't provide regressions
- this implement basic important function for the driver which isn't
that useful without those: to/from native, get os type and
suspend/resume
the most controversial at this point would IMHO be the events, but
honnestly without pushing it, it's gonna be hard to debug.
I did a review, complete but not very thorough of the code and it looks
fine to me.
So overall I'm of the opinion to push this patch set, but I think
JimF should give his ACK too :-)
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list