Re: [libvirt-php] Add lookup function for pool & volume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lyre,

> +		set_error ("Cannot find storage pool" TSRMLS_CC);


This is being set by the function itself and caught using the
catch_error() so please avoid this line in v2 of the patch.


> +	volume=virStorageVolLookupByPath (conn->conn,name);
> +	if (volume==NULL)
> +	{
> +		set_error ("Cannot find volume");
> +		RETURN_FALSE;
> +	}


Same here.

Thanks,
Michal

-- 
Michal Novotny <minovotn@xxxxxxxxxx>, RHCE
Virtualization Team (xen userspace), Red Hat

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]