On 03/18/2011 12:54 PM, Daniel P. Berrange wrote: > This patch defines the basics of a generic RPC protocol in XDR. > This is wire ABI compatible with the original remote_protocol.x. > It takes everything except for the RPC calls / events from that > protocol > > - The basic header virNetMessageHeader (aka remote_message_header) > - The error object virNetMessageError (aka remote_error) > - Two dummy objects virNetMessageDomain & virNetMessageNetwork > sadly needed to keep virNetMessageError ABI compatible with > the old remote_error > > The RPC protocol supports method calls, async events and > bidirectional data streams as before > > diff --git a/cfg.mk b/cfg.mk > index 2076173..a7120e2 100644 > --- a/cfg.mk > +++ b/cfg.mk > @@ -454,7 +454,7 @@ sc_prohibit_newline_at_end_of_diagnostic: > exit 1; } || : > > # Regex for grep -E that exempts generated files from style rules. > -preprocessor_exempt = ((qemu|remote)_(driver|protocol)\.h)$$ > +preprocessor_exempt = ((qemu_|remote_|virnet)(protocol)\.h)$$ Hmm, at first, I was going to complain that this drops qemu_driver.h from exemption. On second glance, that file is neither generated nor does it need an exemption, so that's a good thing! This has some redundant (); how about: preprocessor_exempt = (qemu_|remote_|virnet)protocol\.h$$ > diff --git a/src/rpc/virnetprotocol.x b/src/rpc/virnetprotocol.x > new file mode 100644 > index 0000000..15066b8 > --- /dev/null > +++ b/src/rpc/virnetprotocol.x > @@ -0,0 +1,217 @@ > +/* -*- c -*- > + * virnetprotocol.x: basic protocol for all RPC services. > + * > + * Copyright (C) 2006-2010 Red Hat, Inc. 2011 ACK with those nits fixed. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list