Re: [PATCH] v2: Fix uninitialized variable & error reporting in LXC veth setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/21/2011 09:37 AM, Daniel P. Berrange wrote:
> THe veth setup in LXC had a couple of flaws, first brInit did

s/THe/The/

> not report any error when it failed. Second vethCreate() did
> not correctly initialize the variable containing the return
> code, so could report failure even when it succeeded.
> 
> * src/lxc/lxc_driver.c: Report error when brInit fails
> * src/lxc/veth.c: Fix uninitialized variable
> ---
>  src/lxc/lxc_driver.c |    8 ++++++--
>  src/lxc/veth.c       |   33 ++++++++++++++++++++++-----------
>  2 files changed, 28 insertions(+), 13 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]