On 03/16/2011 01:03 AM, Hu Tao wrote: > Make virDomainObjParseNode() static since it is called only > in one file. > --- > src/conf/domain_conf.c | 38 ++++++++++++++++++++------------------ > src/conf/domain_conf.h | 3 --- > 2 files changed, 20 insertions(+), 21 deletions(-) That seemed like a lot of churn, until I realized: > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 16e1291..c637300 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -6081,24 +6081,10 @@ cleanup: > } > > > -virDomainObjPtr virDomainObjParseFile(virCapsPtr caps, > - const char *filename) Oh, you also did code motion in the same patch, moving this function down (or the other one up - diff can't quite tell the difference) to preserve topological use. ACK and pushed. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list