On 03/17/2011 02:26 PM, Alex Williamson wrote:
> I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset
> devices on VM reset. We need to add it to libvirt's list of
> files that get ownership for device assignment.
>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> ---
>
> src/util/pci.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/pci.c b/src/util/pci.c
> index 095ad3f..8d2dbb0 100644
> --- a/src/util/pci.c
> +++ b/src/util/pci.c
> @@ -1349,11 +1349,13 @@ int pciDeviceFileIterate(pciDevice *dev,
>
> while ((ent = readdir(dir)) != NULL) {
> /* Device assignment requires:
> - * $PCIDIR/config, $PCIDIR/resource, $PCIDIR/resourceNNN, $PCIDIR/rom
> + * $PCIDIR/config, $PCIDIR/resource, $PCIDIR/resourceNNN,
> + * $PCIDIR/rom, $PCIDIR/reset
Hmm, in the case of hot-plug, we are already passing the config fd via
SCM_RIGHTS rather than having qemu directly open it. Should we be
passing all of these files via SCM_RIGHTS?
> */
> if (STREQ(ent->d_name, "config") ||
> STRPREFIX(ent->d_name, "resource") ||
> - STREQ(ent->d_name, "rom")) {
> + STREQ(ent->d_name, "rom") ||
> + STREQ(ent->d_name, "reset")) {
At any rate, this looks reasonable to me, so ACK, and I'll push it shortly.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list