On 03/15/2011 06:30 AM, Daniel P. Berrange wrote: > + if (offset && > + lseek(fd, offset, SEEK_SET) != offset) { > + virReportSystemError(errno, > + _("Unable to seek %s to %llu"), > + path, offset); > + goto error; > + } One more thing to think about - since unsigned long long is unsigned, but off_t used by lseek is signed, do we need to worry about overflow or other out-of-bounds problems? -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list