Re: [PATCH] Include stdint.h in libvirt.h for INT64_MAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/3/9 Eric Blake <eblake@xxxxxxxxxx>:
> On 03/09/2011 06:47 AM, Daniel Veillard wrote:
>>> Instead of including stdint.h specify the value directly.
>>> ---
>>> Âinclude/libvirt/libvirt.h.in | Â Â2 +-
>>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
>>> index 618b350..82e45d7 100644
>>> --- a/include/libvirt/libvirt.h.in
>>> +++ b/include/libvirt/libvirt.h.in
>>> @@ -705,7 +705,7 @@ typedef enum {
>>> Â * Macro providing the virMemoryParameter value that indicates "unlimited"
>>> Â */
>>>
>>> -#define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED (INT64_MAX >> 10)
>>> +#define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED 9007199254740991 /* = INT64_MAX >> 10 */
>>
>> Â Hum shouldn't that be 9007199254740991UL to provide type information ?
>
> UL still won't work on 32-bit platforms. ÂYou need the LL (or ULL) suffix.
>

And now the final v3 for something that should have been a trivial patch :)

Matthias

Attachment: 0001-Don-t-use-INT64_MAX-in-libvirt.h-because-it-requires.patch
Description: application/mbox

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]