On Wed, Mar 09, 2011 at 07:18:30PM -0700, Eric Blake wrote: > Direct access to an open file is so much simpler than passing > everything through a pipe! Did you test with SELinux in enforcing mode - there's a very slight chance this could impact things, though I think we do label all FDs correctly these days. > * src/qemu/qemu_driver.c (qemudOpenAsUID) > (qemudDomainSaveImageClose): Delete. > (qemudDomainSaveImageOpen): Rename... > (qemuDomainSaveImageOpen): ...and drop read_pid argument. Use > virFileOpenAs instead of qemudOpenAsUID. > (qemudDomainSaveImageStartVM, qemudDomainRestore) > (qemudDomainObjRestore): Rename... > (qemuDomainSaveImageStartVM, qemuDomainRestore) > (qemDomainObjRestore): ...and simplify accordingly. > (qemudDomainObjStart, qemuDriver): Update callers. > --- > src/qemu/qemu_driver.c | 265 ++++++++--------------------------------------- > 1 files changed, 45 insertions(+), 220 deletions(-) ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list