Re: [PATCHv2] unlock eventLoop before calling callback function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/07/2011 10:18 AM, Daniel P. Berrange wrote:
> On Mon, Mar 07, 2011 at 10:09:36AM -0700, Eric Blake wrote:
>> From: Wen Congyang <wency@xxxxxxxxxxxxxx>
>>
>> When I use newest libvirt to save a domain, libvirtd will be deadlock.
>>
>> The reason is that we will try to lock some object in callback function, and we may call event API with locking the same object.
>> In the function virEventDispatchHandles(), we unlock eventLoop before calling callback function. I think we should
>> do the same thing in the function virEventCleanupTimeouts() and virEventCleanupHandles().
>>
>> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>
>> v2: incorporate comments from reviewers, and rebase on top of file move
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]