On Thu, 03 Mar 2011 17:06:05 -0700 Eric Blake <eblake@xxxxxxxxxx> wrote: > On 03/03/2011 04:40 PM, KAMEZAWA Hiroyuki wrote: > > On Thu, 3 Mar 2011 10:07:40 +0900 > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > > > >> > >> Now, Xen supports at(de)tach-disk, at(de)tach-interface for inactive domains > >> with --perisitent option. (Using --persisten against live domain will > >> cause error.) > >> > >> Now, virsh attach-xxx/detach-xxx cannot modify inactive domains in qemu and > >> --persistent option just returns error. > >> > >> This series adds support for modification of inactive domain's disk, interfaces. > >> > >> Short description > >> 1 ... clean up for Xen's driver > >> 2 ... add my name to AUTHORS > >> 3 ... add --persistent modification support, just a wrapper function. > >> 4 ... add disk support > >> 5 ... add nics support > >> > > > > What's bad with this patches ? > > Personally, I think they are a good addition, but I haven't yet had time > to review them closely for potential coding gotchas. Rest assured, it's > on my todo list, and either these patches, or a further refined version, > will be included in the next libvirt release. > > > > > If libvirt never supports modification of XML in virsh *** command, > > I'll change my direction and send patches to virtinst. > > Sorry for the delays; it's been a busy week (I've been swamped trying to > debug libvirt crashes, which takes a higher priority on my plate over > libvirt feature additions). Don't give up yet; and it's fine to ping us > every few days if we continue to drag our feet! > Okay, thank you for reply. I should be more patient. BTW, what's crash ? Sorry, -Kame -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list