On Tue, Mar 01, 2011 at 09:02:23PM -0700, Eric Blake wrote: > qemudDomainSaveImageStartVM was evil - it closed the incoming fd > argument on some, but not all, code paths, without informing the > caller about that action. No wonder that this resulted in > double-closes: https://bugzilla.redhat.com/show_bug.cgi?id=672725 > > * src/qemu/qemu_driver.c (qemudDomainSaveImageStartVM): Alter > signature, to avoid double-close. > (qemudDomainRestore, qemudDomainObjRestore): Update callers. > --- > src/qemu/qemu_driver.c | 21 +++++++++++---------- > 1 files changed, 11 insertions(+), 10 deletions(-) ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list