On Tue, Feb 22, 2011 at 10:26:13 -0700, Eric Blake wrote: > I didn't spot any obvious changes from v1. The only remaining hits for > 'git grep "qemuCmdFlags &"' were in docs/api_extension; but rewriting > past patches is an awkward game to play, so I'm fine with leaving them > alone. Yeah, I left them alone intentionally :-) > You missed my comment against v1 about at least mentioning the names of > the new helper methods in the commit message, so that 'git log' makes it > easier to search for their introduction: > https://www.redhat.com/archives/libvir-list/2011-February/msg00264.html Oops, I fixed that. > 'git grep "|= QEMU_CAPS"' shows that you missed a change that happened > since v1: tests/qemuxml2argvtest.c added 'flags |= QEMU.*PCI_MULTIBUS', > which should be converted as well (although I'm sure that it gets > re-converted later in this series, we might as well make each patch > complete rather than relying on later patches to touch it up). I did a similar git grep but apparently I missed this single instance in the output :-( Thanks for spotting that. > ACK with those two nits fixed. Thanks and pushed. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list