On 02/16/2011 08:32 PM, Wen Congyang wrote:
> When we attach a disk, but we specify a wrong format of disk image,
> qemu monitor command drive_add will fail, but libvirt does not detect
> this error.
>
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
>
> ---
> src/qemu/qemu_monitor_text.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
> index 6d0ba4c..0fd7546 100644
> --- a/src/qemu/qemu_monitor_text.c
> +++ b/src/qemu/qemu_monitor_text.c
> @@ -2453,6 +2453,12 @@ int qemuMonitorTextAddDrive(qemuMonitorPtr mon,
> goto cleanup;
> }
>
> + if (strstr(reply, "could not open disk image")) {
> + qemuReportError(VIR_ERR_OPERATION_FAILED, "%s",
> + _("open disk image file failed"));
> + goto cleanup;
> + }
ACK and pushed.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list