Markus Groà wrote: > Hi, > > I refactored the XM and SEXPR parsing routines from the xen-unified > driver into a seperate directory (xenxs; x for xm and s for sexpr). > This way different xen-drivers besides xen-unified are able to > use the parsing functionality. For example the upcoming > XenLight (libxl) driver. > To use the XM parsing functions one includes "xen_xm.h" and for SEXPR parsing "xen_sxpr.h". > libxl does not support sexpr at all so I don't think there is a need to move that code, only the xm config parsing functions. Regards, Jim > The patch is rather big, but most of it are code movements. > Some parsing functions required a driver object to fetch the tty path and vncport. > I removed all references to a specific driver and added > additional parameters as a replacement. > > The tests sexpr2xml, xmconfig and xml2sexpr are adapted and show no error. > > Thanks in advance for your comments about this. > > Cheers, > Markus > > Markus Groà (2): > Moved Xen SEXPR and XM parsing functionality to seperate directory. > Added to authors to please make syntax-check > > AUTHORS | 1 + > configure.ac | 4 + > include/libvirt/virterror.h | 2 +- > src/Makefile.am | 15 +- > src/util/virterror.c | 4 +- > src/xen/sexpr.c | 568 ---- > src/xen/sexpr.h | 55 - > src/xen/xen_driver.c | 19 +- > src/xen/xend_internal.c | 6673 ++++++++++++++----------------------------- > src/xen/xend_internal.h | 30 - > src/xen/xm_internal.c | 1706 +----------- > src/xen/xm_internal.h | 3 - > src/xenxs/sexpr.c | 647 +++++ > src/xenxs/sexpr.h | 63 + > src/xenxs/xen_sxpr.c | 2149 ++++++++++++++ > src/xenxs/xen_sxpr.h | 62 + > src/xenxs/xen_xm.c | 1716 +++++++++++ > src/xenxs/xen_xm.h | 41 + > src/xenxs/xenxs_private.h | 63 + > tests/sexpr2xmltest.c | 12 +- > tests/xmconfigtest.c | 5 +- > tests/xml2sexprtest.c | 4 +- > 22 files changed, 7012 insertions(+), 6830 deletions(-) > delete mode 100644 src/xen/sexpr.c > delete mode 100644 src/xen/sexpr.h > create mode 100644 src/xenxs/sexpr.c > create mode 100644 src/xenxs/sexpr.h > create mode 100644 src/xenxs/xen_sxpr.c > create mode 100644 src/xenxs/xen_sxpr.h > create mode 100644 src/xenxs/xen_xm.c > create mode 100644 src/xenxs/xen_xm.h > create mode 100644 src/xenxs/xenxs_private.h > > > ------------------------------------------------------------------------ > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list