ä 2011å02æ16æ 12:04, Gui Jianfeng åé:
Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu
Signed-off-by: Gui Jianfeng<guijianfeng@xxxxxxxxxxxxxx>
---
src/qemu/qemu_driver.c | 164 +++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 162 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 882f323..73ecd07 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -93,6 +93,7 @@
#define QEMU_NB_MEM_PARAM 3
+#define QEMU_NB_BLKIO_PARAM 1
#define timeval_to_ms(tv) (((tv).tv_sec * 1000ull) + ((tv).tv_usec / 1000))
@@ -7009,6 +7010,165 @@ cleanup:
return ret;
}
+static int qemuDomainSetBlkioParameters(virDomainPtr dom,
+ virBlkioParameterPtr params,
+ int nparams,
+ unsigned int flags ATTRIBUTE_UNUSED)
+{
+ struct qemud_driver *driver = dom->conn->privateData;
+ int i;
+ virCgroupPtr group = NULL;
+ virDomainObjPtr vm = NULL;
+ int ret = -1;
+
+ qemuDriverLock(driver);
+ if (!qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_BLKIO)) {
+ qemuReportError(VIR_ERR_NO_SUPPORT,
+ __FUNCTION__);
Eric made patch to replace "__FUNCTION__" with descriptive
string in d9b0494779, so perhaps it shouldn't introduced
again.
+ goto cleanup;
+ }
+
+ vm = virDomainFindByUUID(&driver->domains, dom->uuid);
+
+ if (vm == NULL) {
+ qemuReportError(VIR_ERR_INTERNAL_ERROR,
+ _("No such domain %s"), dom->uuid);
+ goto cleanup;
+ }
+
+ if (virCgroupForDomain(driver->cgroup, vm->def->name,&group, 0) != 0) {
+ qemuReportError(VIR_ERR_INTERNAL_ERROR,
+ _("cannot find cgroup for domain %s"), vm->def->name);
+ goto cleanup;
+ }
+
+ ret = 0;
+ for (i = 0; i< nparams; i++) {
+ virBlkioParameterPtr param =¶ms[i];
+
+ if (STREQ(param->field, VIR_DOMAIN_BLKIO_WEIGHT)) {
+ int rc;
+ if (param->type != VIR_DOMAIN_BLKIO_PARAM_UINT) {
+ qemuReportError(VIR_ERR_INVALID_ARG, "%s",
+ _("invalid type for blkio weight tunable, expected a 'unsigned int'"));
+ ret = -1;
+ continue;
+ }
+
+ if (params[i].value.ui> 1000 || params[i].value.ui< 100) {
+ qemuReportError(VIR_ERR_INVALID_ARG, "%s",
+ _("out of blkio weight range."));
+ ret = -1;
+ continue;
+ }
+
+ rc = virCgroupSetBlkioWeight(group, params[i].value.ui);
+ if (rc != 0) {
+ virReportSystemError(-rc, "%s",
+ _("unable to set blkio weight tunable"));
+ ret = -1;
+ }
+ } else {
+ qemuReportError(VIR_ERR_INVALID_ARG,
+ _("Parameter `%s' not supported"), param->field);
+ ret = -1;
+ }
+ }
+
+cleanup:
+ virCgroupFree(&group);
+ if (vm)
+ virDomainObjUnlock(vm);
+ qemuDriverUnlock(driver);
+ return ret;
+}
+
+static int qemuDomainGetBlkioParameters(virDomainPtr dom,
+ virBlkioParameterPtr params,
+ int *nparams,
+ unsigned int flags ATTRIBUTE_UNUSED)
+{
+ struct qemud_driver *driver = dom->conn->privateData;
+ int i;
+ virCgroupPtr group = NULL;
+ virDomainObjPtr vm = NULL;
+ unsigned int val;
+ int ret = -1;
+ int rc;
+
+ qemuDriverLock(driver);
+
+ if (!qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_BLKIO)) {
+ qemuReportError(VIR_ERR_NO_SUPPORT,
+ __FUNCTION__);
likewise
+ goto cleanup;
+ }
+
+ vm = virDomainFindByUUID(&driver->domains, dom->uuid);
+
+ if (vm == NULL) {
+ qemuReportError(VIR_ERR_INTERNAL_ERROR,
+ _("No such domain %s"), dom->uuid);
+ goto cleanup;
+ }
+
+ if ((*nparams) == 0) {
+ /* Current number of blkio parameters supported by cgroups */
+ *nparams = QEMU_NB_BLKIO_PARAM;
+ ret = 0;
+ goto cleanup;
+ }
+
+ if ((*nparams) != QEMU_NB_BLKIO_PARAM) {
+ qemuReportError(VIR_ERR_INVALID_ARG,
+ "%s", _("Invalid parameter count"));
+ goto cleanup;
+ }
+
+ if (virCgroupForDomain(driver->cgroup, vm->def->name,&group, 0) != 0) {
+ qemuReportError(VIR_ERR_INTERNAL_ERROR,
+ _("cannot find cgroup for domain %s"), vm->def->name);
+ goto cleanup;
+ }
+
+ for (i = 0; i< *nparams; i++) {
+ virBlkioParameterPtr param =¶ms[i];
+ val = 0;
+ param->value.ui = 0;
+ param->type = VIR_DOMAIN_BLKIO_PARAM_UINT;
+
+ switch(i) {
+ case 0: /* fill blkio weight here */
+ rc = virCgroupGetBlkioWeight(group,&val);
+ if (rc != 0) {
+ virReportSystemError(-rc, "%s",
+ _("unable to get blkio weight"));
+ goto cleanup;
+ }
+ if (virStrcpyStatic(param->field, VIR_DOMAIN_BLKIO_WEIGHT) == NULL) {
+ qemuReportError(VIR_ERR_INTERNAL_ERROR,
+ "%s", _("Field blkio weight too long for destination"));
+ goto cleanup;
+ }
+ param->value.ui = val;
+ break;
+
+ default:
+ break;
+ /* should not hit here */
+ }
+ }
+
+ ret = 0;
+
+cleanup:
+ if (group)
+ virCgroupFree(&group);
+ if (vm)
+ virDomainObjUnlock(vm);
+ qemuDriverUnlock(driver);
+ return ret;
+}
static int qemuDomainSetMemoryParameters(virDomainPtr dom,
virMemoryParameterPtr params,
@@ -10502,8 +10662,8 @@ static virDriver qemuDriver = {
qemuDomainSetMemoryParameters, /* domainSetMemoryParameters */
qemuDomainGetMemoryParameters, /* domainGetMemoryParameters */
qemuDomainOpenConsole, /* domainOpenConsole */
- NULL, /* domainSetBlkioParameters */
- NULL, /* domainGetBlkioParameters */
+ qemuDomainSetBlkioParameters, /* domainSetBlkioParameters */
+ qemuDomainGetBlkioParameters, /* domainGetBlkioParameters */
};
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list